feat: HITL one-time approve/reject link (issue #133 slice 1) #152

Merged
Marc merged 2 commits from feat/issue-133-hitl-approve-link into main 2026-08-17 07:09:45 +00:00
Contributor

Summary

  • Nieuwe orchestrator-stap wait_for_approval met ADR 0007-checkpoint pause/resume
  • Eénmalige approve/reject-token + publieke Dashboard-pagina /approve/{token}
  • Demo workflow hitl_approve_demo + HTTP-trigger (start contract schema)

Test plan

  • python flows/scripts/validate_triggers.py — 42 triggers OK
  • pytest tests/test_hitl_*.py lokaal groen
  • Branch CI: test.yml + build.yml groen

Leftover (#133 blijft open)

  • E-mail/notificatie met link, Dashboard taken-inbox, queue/dehydrate-pad, prod DB-migratie 0003_hitl_approval.sql
## Summary - Nieuwe orchestrator-stap `wait_for_approval` met ADR 0007-checkpoint pause/resume - Eénmalige approve/reject-token + publieke Dashboard-pagina `/approve/{token}` - Demo workflow `hitl_approve_demo` + HTTP-trigger (start contract schema) ## Test plan - [x] `python flows/scripts/validate_triggers.py` — 42 triggers OK - [x] `pytest tests/test_hitl_*.py` lokaal groen - [x] Branch CI: test.yml + build.yml groen ## Leftover (#133 blijft open) - E-mail/notificatie met link, Dashboard taken-inbox, queue/dehydrate-pad, prod DB-migratie `0003_hitl_approval.sql`
feat(orchestrator): HITL one-time approve/reject link (issue #133)
Some checks failed
Build & Push Docker Images / Detect Changed Components (push) Successful in 9s
Build & Push Docker Images / Validate Repository Structure (push) Successful in 3s
Test & Validate / Test Engine Smoke Suite (pytest) (push) Successful in 46s
Build & Push Docker Images / Validate Workflow YAML (push) Failing after 13s
Build & Push Docker Images / Validate Kubernetes Manifests (push) Successful in 5s
Deploy to Cluster / Validate Flows Before Deploy (push) Failing after 10s
Build & Push Docker Images / Build Forgejo Runner Image (push) Has been skipped
Build & Push Docker Images / Test Engine Smoke Suite (pytest) (push) Successful in 41s
Build & Push Docker Images / Sync compact pointer to Forgejo Wiki (push) Has been skipped
Build & Push Docker Images / Build (dashboard) Engine Services [./engine/services/dashboard] (dashboard, ./engine/services/dashboard) (push) Successful in 27s
Build & Push Docker Images / Build Wiki (MkDocs) (push) Successful in 34s
Test & Validate / Test Summary (push) Failing after 0s
Build & Push Docker Images / Test Summary (push) Failing after 0s
Build & Push Docker Images / Test Gate (push) Failing after 0s
Deploy to Cluster / Resolve Environment (push) Has been skipped
Deploy to Cluster / List Recent Release Bundles (push) Failing after 0s
Deploy to Cluster / Resolve Release Bundle (push) Failing after 0s
Deploy to Cluster / Deploy Platform Data (push) Failing after 0s
Deploy to Cluster / Deploy Engine (push) Failing after 0s
Deploy to Cluster / Deploy Wiki (push) Failing after 0s
Deploy to Cluster / Deploy Workflows (push) Failing after 0s
Deploy to Cluster / Rollback on Deploy Failure (push) Failing after 0s
Build & Push Docker Images / Build (orchestrator) Engine Services [./engine/services/orchestrator] (orchestrator, ./engine/services/orchestrator) (push) Successful in 19s
Build & Push Docker Images / Retag Product Version (push) Successful in 0s
Build & Push Docker Images / Publish Release Bundle (push) Has been skipped
Build & Push Docker Images / Resolve Auto-Deploy Targets (push) Has been skipped
Build & Push Docker Images / Trigger Deploy DEV (dev) (push) Has been skipped
Build & Push Docker Images / Build Summary (push) Successful in 0s
Build & Push Docker Images / Trigger Deploy TST/LAB (tst) (push) Has been skipped
Build & Push Docker Images / Trigger Deploy TST/LAB (lab) (push) Has been skipped
1fdb58922a
Add wait_for_approval step, token store, checkpoint pause/resume, and a public Dashboard approval page so long-running workflows can wait for human decisions.

Co-authored-by: Cursor <cursoragent@cursor.com>
fix(flows): align hitl-approve trigger with start contract schema
All checks were successful
Build & Push Docker Images / Trigger Deploy DEV (dev) (push) Successful in 1s
Build & Push Docker Images / Trigger Deploy TST/LAB (lab) (push) Has been skipped
Build & Push Docker Images / Trigger Deploy TST/LAB (tst) (push) Has been skipped
Deploy to Cluster / Deploy Workflows (push) Successful in 30s
Build & Push Docker Images / Runner Preflight (pull_request) Successful in 0s
Build & Push Docker Images / Validate JavaScript Syntax (pull_request) Successful in 5s
Test & Validate / Validate Repository Structure (pull_request) Successful in 4s
Test & Validate / Validate Workflow YAML (pull_request) Successful in 15s
Test & Validate / Validate Kubernetes Manifests (pull_request) Successful in 5s
Build & Push Docker Images / Detect Changed Components (pull_request) Successful in 12s
Build & Push Docker Images / Validate Repository Structure (pull_request) Successful in 4s
Test & Validate / Test Engine Smoke Suite (pytest) (pull_request) Successful in 45s
Build & Push Docker Images / Validate Workflow YAML (pull_request) Successful in 14s
Build & Push Docker Images / Validate Kubernetes Manifests (pull_request) Successful in 6s
Build & Push Docker Images / Build Forgejo Runner Image (pull_request) Has been skipped
Build & Push Docker Images / Build Wiki (MkDocs) (pull_request) Successful in 5s
Build & Push Docker Images / Sync compact pointer to Forgejo Wiki (pull_request) Has been skipped
Build & Push Docker Images / Test Engine Smoke Suite (pytest) (pull_request) Successful in 44s
Build & Push Docker Images / Build (dashboard) Engine Services [./engine/services/dashboard] (dashboard, ./engine/services/dashboard) (pull_request) Successful in 31s
Build & Push Docker Images / Build (orchestrator) Engine Services [./engine/services/orchestrator] (orchestrator, ./engine/services/orchestrator) (pull_request) Successful in 25s
Test & Validate / Test Summary (pull_request) Successful in 0s
Build & Push Docker Images / Test Summary (pull_request) Successful in 0s
Build & Push Docker Images / Test Gate (pull_request) Successful in 0s
Build & Push Docker Images / Retag Product Version (pull_request) Successful in 0s
Build & Push Docker Images / Publish Release Bundle (pull_request) Successful in 1s
Build & Push Docker Images / Resolve Auto-Deploy Targets (pull_request) Successful in 0s
Build & Push Docker Images / Build Summary (pull_request) Successful in 0s
Build & Push Docker Images / Trigger Deploy DEV (dev) (pull_request) Successful in 1s
Build & Push Docker Images / Trigger Deploy TST/LAB (lab) (pull_request) Has been skipped
Build & Push Docker Images / Trigger Deploy TST/LAB (tst) (pull_request) Has been skipped
4176e2a1d7
Use target_workflow and invocation block like other HTTP triggers so validate_triggers passes in CI.

Co-authored-by: Cursor <cursoragent@cursor.com>
Marc merged commit ebcba14efc into main 2026-08-17 07:09:45 +00:00
Sign in to join this conversation.
No description provided.