feat: mail HITL one-time approve link (#133) #174

Merged
meshflows merged 1 commit from feat/issue-133-hitl-approval-email into main 2026-08-31 12:58:25 +00:00
Owner

Summary

  • wait_for_approval kan optioneel de eenmalige /approve/{token}-link mailen via egress.smtp.call voordat de run pauzeert (notify.connection / notify.to_emails).
  • SMTP-falen stopt de step (geen stille pause zonder mail). Designer-velden + demo hitl_approve_email_demo.
  • Bestaande HITL-demo extract-YAML gecorrigeerd naar input_from / json_path / context_key.

Test plan

  • pytest engine/tests/test_hitl_email.py engine/tests/test_hitl_workflow.py
  • Demo hitl_approve_email_demo: mail komt aan, link is eenmalig, resume na goedkeuren/afwijzen
  • Zonder notify blijft hitl_approve_demo pauseren via de pagina
## Summary - `wait_for_approval` kan optioneel de eenmalige `/approve/{token}`-link mailen via `egress.smtp.call` voordat de run pauzeert (`notify.connection` / `notify.to_emails`). - SMTP-falen stopt de step (geen stille pause zonder mail). Designer-velden + demo `hitl_approve_email_demo`. - Bestaande HITL-demo extract-YAML gecorrigeerd naar `input_from` / `json_path` / `context_key`. ## Test plan - [ ] `pytest engine/tests/test_hitl_email.py engine/tests/test_hitl_workflow.py` - [ ] Demo `hitl_approve_email_demo`: mail komt aan, link is eenmalig, resume na goedkeuren/afwijzen - [ ] Zonder `notify` blijft `hitl_approve_demo` pauseren via de pagina
feat: mail HITL one-time approve link (#133)
All checks were successful
Build & Push Docker Images / Build Summary (push) Successful in 0s
Build & Push Docker Images / Trigger Deploy DEV (dev) (push) Successful in 0s
Build & Push Docker Images / Trigger Deploy TST/LAB (tst) (push) Has been skipped
Build & Push Docker Images / Trigger Deploy TST/LAB (lab) (push) Has been skipped
Deploy to Cluster / Deploy Workflows (push) Successful in 31s
Build & Push Docker Images / Runner Preflight (pull_request) Successful in 0s
Build & Push Docker Images / Validate JavaScript Syntax (pull_request) Successful in 4s
Test & Validate / Validate Repository Structure (pull_request) Successful in 3s
Test & Validate / Validate Workflow YAML (pull_request) Successful in 14s
Test & Validate / Validate Kubernetes Manifests (pull_request) Successful in 5s
Build & Push Docker Images / Detect Changed Components (pull_request) Successful in 9s
Build & Push Docker Images / Validate Repository Structure (pull_request) Successful in 3s
Test & Validate / Test Engine Smoke Suite (pytest) (pull_request) Successful in 43s
Build & Push Docker Images / Validate Workflow YAML (pull_request) Successful in 13s
Build & Push Docker Images / Validate Kubernetes Manifests (pull_request) Successful in 5s
Build & Push Docker Images / Build Forgejo Runner Image (pull_request) Has been skipped
Build & Push Docker Images / Build Wiki (MkDocs) (pull_request) Successful in 4s
Build & Push Docker Images / Sync compact pointer to Forgejo Wiki (pull_request) Has been skipped
Build & Push Docker Images / Test Engine Smoke Suite (pytest) (pull_request) Successful in 42s
Test & Validate / Test Summary (pull_request) Successful in 0s
Build & Push Docker Images / Test Summary (pull_request) Successful in 0s
Build & Push Docker Images / Test Gate (pull_request) Successful in 0s
Build & Push Docker Images / Build (orchestrator) Engine Services [./engine/services/orchestrator] (orchestrator, ./engine/services/orchestrator) (pull_request) Successful in 19s
Build & Push Docker Images / Retag Product Version (pull_request) Successful in 0s
Build & Push Docker Images / Publish Release Bundle (pull_request) Successful in 1s
Build & Push Docker Images / Resolve Auto-Deploy Targets (pull_request) Successful in 0s
Build & Push Docker Images / Build Summary (pull_request) Successful in 0s
Build & Push Docker Images / Trigger Deploy DEV (dev) (pull_request) Successful in 0s
Build & Push Docker Images / Trigger Deploy TST/LAB (lab) (pull_request) Has been skipped
Build & Push Docker Images / Trigger Deploy TST/LAB (tst) (pull_request) Has been skipped
5ac9115722
Optional wait_for_approval.notify sends the Dashboard URL via SMTP before the run pauses.

Co-authored-by: Cursor <cursoragent@cursor.com>
meshflows changed title from feat: mail HITL one-time approve link (#133) to WIP: feat: mail HITL one-time approve link (#133) 2026-08-31 12:42:33 +00:00
meshflows changed title from WIP: feat: mail HITL one-time approve link (#133) to feat: mail HITL one-time approve link (#133) 2026-08-31 12:57:45 +00:00
Sign in to join this conversation.
No description provided.