Security: HITL-formulier zonder CSRF, token-metadata en SES-sandbox #196
Labels
No labels
prio/P1
prio/P2
prio/P3
status/leftover
status/new
status/parked
type/feature
type/ops
type/research
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MeshFlowsGPL/meshflows#196
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
Security review (2026-09-22). Lagere prioriteit, wel echte gaten.
Bevindingen
POST /approve/{token}is een HTML-formulier zonder CSRF-nonce.engine/services/dashboard/app/hitl_approve_page.pyrond 96-100 enmain.pyrond 4054. Een gelekt token plus cross-site POST kan approve/reject forceren.GET /api/hitl/tokens/{token}op de orchestrator geeft run-context zonder extra auth. Rond 4470-4487. Token-lek is meteen context-lek./dashboardnaar het dashboard, niet/approve/{token}.engine/deploy/k8s/ingress.yamlversus dashboard-route. Operators vallen terug op port-forward; de approval-URL klopt niet met de HTTPRoute.SES_SERVICE_TOKEN. Bash-executor draait user code in een subprocess zonder kernel-sandbox.engine/services/script-execution-service.Gewenste uitkomst
/approveof links onder/dashboard/approve.SES_BASH_ENABLED=falsein prod, SES netwerk-geïsoleerd, token-rotatie. Sandbox (gVisor/seccomp) als vervolgstap.