fix: annotate per-env Gateway on TLS IncorrectIssuer #187

Merged
Marc merged 1 commit from fix/lab-deploy-gateway into main 2026-09-17 06:28:50 +00:00
Owner

Summary

  • Lab Deploy Engine failed after #186 because TLS reconcile still annotated Gateway meshflows. Since #182 the Gateway is meshflows-{env} (lab: meshflows-lab), so kubectl annotate returned NotFound and set -e aborted the job before kustomize apply.
  • Reconcile now targets meshflows-${MESHFLOWS_ENV}, skips annotation when the Gateway is not applied yet (pre-kustomize), and runs again after Gateway apply so issuer annotations stick.

No VERSION bump.

Test plan

  • pytest engine/tests/test_reconcile_tls_certificate.py
  • Re-run Deploy to Cluster (lab) after merge; IncorrectIssuer should no longer fail the job. Cert may stay Ready=False until cert-manager accepts the aligned ClusterIssuer annotation.

Refs: lab run https://code.meshflows.org/MeshFlowsGPL/meshflows/actions/runs/2733 (commit e0aa576), leftover from #182.

## Summary - Lab Deploy Engine failed after #186 because TLS reconcile still annotated Gateway `meshflows`. Since #182 the Gateway is `meshflows-{env}` (lab: `meshflows-lab`), so `kubectl annotate` returned NotFound and `set -e` aborted the job before kustomize apply. - Reconcile now targets `meshflows-${MESHFLOWS_ENV}`, skips annotation when the Gateway is not applied yet (pre-kustomize), and runs again after Gateway apply so issuer annotations stick. No VERSION bump. ## Test plan - [x] `pytest engine/tests/test_reconcile_tls_certificate.py` - [ ] Re-run **Deploy to Cluster (lab)** after merge; IncorrectIssuer should no longer fail the job. Cert may stay Ready=False until cert-manager accepts the aligned ClusterIssuer annotation. Refs: lab run https://code.meshflows.org/MeshFlowsGPL/meshflows/actions/runs/2733 (commit e0aa576), leftover from #182.
fix: annotate per-env Gateway on TLS IncorrectIssuer
All checks were successful
Build & Push Docker Images / Sync compact pointer to Forgejo Wiki (pull_request) Has been skipped
Build & Push Docker Images / Validate Repository Structure (pull_request) Successful in 3s
Build & Push Docker Images / Test Engine Smoke Suite (pytest) (push) Successful in 45s
Build & Push Docker Images / Validate Workflow YAML (pull_request) Successful in 13s
Build & Push Docker Images / Validate Kubernetes Manifests (pull_request) Successful in 4s
Test & Validate / Test Summary (push) Successful in 0s
Build & Push Docker Images / Build Wiki (MkDocs) (push) Successful in 2s
Build & Push Docker Images / Build (_noop) Engine Services [.] (_noop, .) (push) Successful in 3s
Test & Validate / Test Summary (pull_request) Successful in 0s
Build & Push Docker Images / Test Engine Smoke Suite (pytest) (pull_request) Successful in 45s
Build & Push Docker Images / Build Wiki (MkDocs) (pull_request) Successful in 3s
Build & Push Docker Images / Build (_noop) Engine Services [.] (_noop, .) (pull_request) Successful in 3s
Build & Push Docker Images / Test Summary (push) Successful in 0s
Build & Push Docker Images / Retag Product Version (push) Successful in 0s
Build & Push Docker Images / Test Gate (push) Successful in 0s
Build & Push Docker Images / Test Summary (pull_request) Successful in 0s
Build & Push Docker Images / Publish Release Bundle (push) Successful in 1s
Build & Push Docker Images / Test Gate (pull_request) Successful in 0s
Build & Push Docker Images / Resolve Auto-Deploy Targets (push) Successful in 0s
Build & Push Docker Images / Retag Product Version (pull_request) Successful in 0s
Build & Push Docker Images / Build Summary (push) Successful in 0s
Build & Push Docker Images / Trigger Deploy DEV (dev) (push) Successful in 0s
Build & Push Docker Images / Trigger Deploy TST/LAB (lab) (push) Has been skipped
Build & Push Docker Images / Trigger Deploy TST/LAB (tst) (push) Has been skipped
Build & Push Docker Images / Publish Release Bundle (pull_request) Successful in 1s
Build & Push Docker Images / Resolve Auto-Deploy Targets (pull_request) Successful in 0s
Build & Push Docker Images / Build Summary (pull_request) Successful in 0s
Build & Push Docker Images / Trigger Deploy DEV (dev) (pull_request) Successful in 0s
Build & Push Docker Images / Trigger Deploy TST/LAB (lab) (pull_request) Has been skipped
Build & Push Docker Images / Trigger Deploy TST/LAB (tst) (pull_request) Has been skipped
ec32999c5e
Co-authored-by: Cursor <cursoragent@cursor.com>
Marc merged commit ccc35cb66a into main 2026-09-17 06:28:50 +00:00
Sign in to join this conversation.
No description provided.